virtio: Inline vring_init() and vring_need_event() functions #569
+19
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these functions should be internal to virtqueue. They should have had no usefulness outside of this file and so moving them should not cause any API issue. This simplifies the virtio ring setup code for later improvements Signed-off-by: Andrew Davis <afd@ti.com>
arnopo
requested changes
Mar 25, 2024
There was a problem hiding this comment.
vring_init() is used at least by Zephyr, so should be kept in the API. https://elixir.bootlin.com/zephyr/latest/source/drivers/ethernet/eth_ivshmem_queue.c#L51
I don't think that vring_need_event() can be used externally. So Ok to me to not apply deprecation process
|
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these functions should be internal to virtqueue. They should have had no usefulness outside of this file and so moving them should not cause any API issue. This simplifies the virtio ring setup code for later improvements