Criterion9 php 8 db handling #904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a check to handle when a query has no results instead of referencing an index that doesn't exist, and return null instead of generating an error.
mbtools
reviewed
Jan 6, 2024
|
|
||
| owa_coreAPI::profile($this, __FUNCTION__, __LINE__); | ||
| } catch(\Exception $e) { | ||
| $result = false; |
There was a problem hiding this comment.
can we log the exception in $this->e->debug() as well, please?
There was a problem hiding this comment.
This may sound silly, but I'm not sure how to edit/update a PR. This would be the first one I have submitted with a request for changes. Is there a preferred process here?
There was a problem hiding this comment.
You can push any changes to the branch you used and they will automatically be included in the PR.
You can also edit individual files manually on GH.com (see menu on right side):
There was a problem hiding this comment.
I added logging of the caught exception. Please let me know if I missed anything getting the PR updated.
Added logging of caught exceptions
|
It's running with your branch on 8.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
/path/to/php cli.php cmd=build) was run locally and any changes were pushedPull request type
Please check the type of change your PR introduces:
This PR includes 2 adjustments to db handling based on changes in how PHP handles/returns things.
What is the current behavior?
PHP 8.x sometimes throws errors from empty query results or any variety of exceptions that could be thrown when using the mysqli query functions.
Issue Number: 893
What is the new behavior?
Less errors produced when using php 8.x (tested with 8.1 & 8.2)
Does this introduce a breaking change?
Docs need to be updated?
Other information