Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS Policy to /api and Log.php endpoints #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maaiins
Copy link
Contributor

@Maaiins Maaiins commented May 17, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tested the changes
  • Build (/path/to/php cli.php cmd=build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

What is the current behavior?

Currently no cors headers are applied

Issue Number: #573

What is the new behavior?

No the log.php and api endpoint adds cors headers when the request origin is valid.

Does this introduce a breaking change?

  • Yes
  • No

Docs need to be updated?

  • Yes
  • No

Other information

@Maaiins Maaiins requested a review from padams May 17, 2020 10:39
@Maaiins Maaiins linked an issue May 17, 2020 that may be closed by this pull request
@padams
Copy link
Collaborator

padams commented May 20, 2020

No rush. Just wanted make sure you saw my comments.

@Maaiins
Copy link
Contributor Author

Maaiins commented May 22, 2020

No rush. Just wanted make sure you saw my comments.

I read all of the discussed stuff ;-) . But at the moment there is not that much time to develop some stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CORS Policy to /api and Log.php endpoints
2 participants