-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test ci reviewer (ignore this) #157
base: master
Are you sure you want to change the base?
Conversation
@@ -17,7 +17,12 @@ | |||
.addOptionalParam("factory", "Address of Title Escrow factory (Optional)") | |||
.setAction(async ({ name, symbol, verify, factory, standalone }, hre) => { | |||
const { ethers, network } = hre; | |||
const { contractAddress } = constants; | |||
const {contractAddress} = constants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace contractAddress
with ·contractAddress·
const {contractAddress} = constants; | |
const { contractAddress } = constants; |
const { contractAddress } = constants; | ||
const {contractAddress} = constants; | ||
|
||
let testUselessVar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'testUselessVar' is defined but never used.
tasks/deploy-token.ts
Outdated
|
||
let testUselessVar; | ||
|
||
var oldSchoolCoolVar = "cool"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'oldSchoolCoolVar' is assigned a value but never used.
@@ -57,7 +62,7 @@ | |||
const initParam = encodeInitParams({ | |||
name, | |||
symbol, | |||
deployer: deployerAddress, | |||
deployer: deployerAddress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
deployer: deployerAddress | |
deployer: deployerAddress, |
@@ -72,7 +77,7 @@ | |||
const token = await deployContract<TradeTrustToken>({ | |||
params: [name, symbol, factoryAddress], | |||
contractName, | |||
hre, | |||
hre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
hre | |
hre, |
@@ -87,7 +92,7 @@ | |||
address: registryAddress, | |||
constructorArgsParams: [name, symbol, factoryAddress], | |||
contract: "contracts/TradeTrustToken.sol:TradeTrustToken", | |||
hre, | |||
hre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
hre | |
hre, |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
||
let testUselessVar; | ||
|
||
let oldSchoolCoolVar = "cool"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'oldSchoolCoolVar' is never reassigned. Use 'const' instead.
let oldSchoolCoolVar = "cool"; | |
const oldSchoolCoolVar = "cool"; |
|
||
let testUselessVar; | ||
|
||
let oldSchoolCoolVar = "cool"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'oldSchoolCoolVar' is assigned a value but never used.
Summary
Ignore this. Testing CI reviewer.
Changes
Issues
Releases
Channels: -