Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore document store issued fragment for self signed document #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nebulis
Copy link
Contributor

@Nebulis Nebulis commented Jun 3, 2020

@yehjxraymond @AdamJLemmon

First MR that skips OpenAttestationEthereumDocumentStoreIssued when the document contains a proof block.

Note that this detection only works for v2 document. V3 document being aligned on W#C VC will always have a proof block and thus we will need to check on the type of the proof instead

@AdamJLemmon
Copy link
Contributor

This looks good to me @Nebulis

Simple enough, if it is signed.. skip. This should allow us to immediately use a documentStore for only revocation :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants