Install fixes via eric #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first install, we won't have certs but will want to issue a challenge. Dont' assume it's missing.
|
I haven't "officially" released 4.0 yet. It's still on 4.0-alpha, until next week, to check we have ironed out all the bugs. So I guess we might as well merge this now, and make it part of the 4.0 release? |
|
Could do, but I'm assuming you'll merge |
|
Yeah, sorry, I mean merge this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixups to
install_nginx.shfrom Eric.There's no huge rush @hyanwong, the challenge path changes are only relevant to a new server, and I think Eric has manually changed the logging location anyway.
I'm guessing there'll be a bugfix release at some point, and they can make their way to production then.