Fixed threatened_branch() to exclude extinct species. #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lentinj
reviewed
Jan 23, 2024
| @@ -412,10 +412,11 @@ class Midnode { | |||
| num_threatened += this.get_attribute("iucnEN"); | |||
| num_threatened += this.get_attribute("iucnCR"); | |||
| } | |||
| let num_extant = this.richness_val - (this.get_attribute("iucnEX") + this.get_attribute("iucnEW")); | |||
There was a problem hiding this comment.
Why not add these to num_threatened as with the other values, rather than subtracting from richness_val? I don't think that num_extant does what you want:
num_threatened > num_extant * 0.5
==> iucnVU + iucnEN + iucnCR > richness * 0.5 - (iucnEX + iucnEW) * 0.5
==> iucnVU + iucnEN + iucnCR + (iucnEX + iucnEW) * 0.5 > richness * 0.5
==> iucnVU + iucnEN + iucnCR + iucnEX * 0.5 + iucnEW * 0.5 > richness * 0.5
There was a problem hiding this comment.
I'm going with the definition here under Categories:
https://en.m.wikipedia.org/wiki/IUCN_Red_List
I read your expansion but I think it does what we want. It's confusing to expand because the extinct categories are actually adding to richness already, so this removes them from the calculation.
wolfmanstout
force-pushed
the
threatened_branch_fix
branch
from
140414e
to
d101a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way that threatened_branch() was being calculated, a branch consisting entirely of threatened and extinct species could get marked as not threatened. This excludes extinct species from the calculation.