Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing reject for init #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fehergeri13
Copy link

When I init the oneSignal sdk with some invalid config, I get the following error:

try {
    await OneSignal.init({ appId: "example app id" });
} catch(e) {
    console.log("error with init")
}
Uncaught (in promise) Error: OneSignalSDK: HTTP sites are no longer supported starting with version 16 (User Model), your public site must start with https://. Please visit the OneSignal dashboard's Settings > Web Configuration to find this option.

This is an example error. The main issue is that the error is uncaught.

This PR will fix the uncaught exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant