Android: on destroy, set this.registeredEvents = false; #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for android RN restart issue: OneSignal#583
|
the new release seems to work fine for me so this fix is probably not needed anymore |
|
@slorber Thanks for the PR and following up! @slorber @Nightsd01 Can you test if pressing the back button to close the app then opening a notification still properly fires the open event to the javascript side? This is the only edge case I can think. If this is not an issue then I think we can close this PR. For future reference this builds on PR #592. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for android RN restart issue: #583
This change is