Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge major_release_5.0.0 into main #1648

Merged
merged 180 commits into from Mar 13, 2024
Merged

Merge major_release_5.0.0 into main #1648

merged 180 commits into from Mar 13, 2024

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Feb 12, 2024

Description

One Line Summary

This PR will merge major_release_5.0.0 changes into main.

Details

See here for a comparison of this branch vs. major_release_5.0.0.. After this PR, main and major_release_5.0.0 should be equivalent.

Note: main and user model diverged on January 4, 2023.

I have compared all changes on main and cherry-picked the merge commits.

To make the main branch reflect v5.x.x., the "old" main branch is maintained in branch 3.x.x_patch_branch.

Testing

Manual testing

Built and ran new branch on Android 13 emulator and iOS 17.2 emulator. Tested various methods to ensure everything is working.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

dependabot bot and others added 30 commits January 4, 2023 22:05
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts:
#	android/build.gradle
#	examples/RNOneSignalTS/package.json
#	package.json
#	react-native-onesignal.podspec
[User Model] Release 5.0.0 Beta 1
jennantilla and others added 24 commits March 12, 2024 13:09
Update Push Subscription/Permission Getters to Async
- add getters for onesignal ID/external ID
- add user state observer
Add getters and observer for onesignal ID and external ID
Native:
- Android 5.1.6
- iOS 5.1.3

Wrapper:
- RN 5.1.0
Adding a new github action that allows us to measure issue response time
Update the eslint version to resolve npm install error
Bump ios 3.12.4 -> 3.12.6
Bump android 4.8.5 -> 4.8.6
@jennantilla jennantilla requested review from nan-li and removed request for nan-li March 12, 2024 22:45
@jennantilla jennantilla merged commit ced01ce into main Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants