New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] Run Prettier #1528
[User Model] Run Prettier #1528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the lint changes LGTM except the migration guide since it is poor at linting tables.
I think we have to manually go through the migration guide, or exclude the migration guide from lint rules.
We can exclude the migration guide from linting but I do like some of the changes it made. So, I think we can accept most of the changes it made on non-table parts, and manually do the table changes ourselves to comply with the lint rules.
"rootDir": "src", | ||
"declaration": true, | ||
"allowSyntheticDefaultImports": true, | ||
"skipLibCheck": true, | ||
"esModuleInterop": true, | ||
"strict": true, | ||
"noUnusedLocals": true, | ||
"noUnusedLocals": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why they removed the last comma here (which I think it should be there), but in other examples, added the last comma. Such as in "src/models/Subscription.ts" they added a comma after Ephemeral
🤷🏻♀️
a096ed8
into
user_model_beta2/rename_events
Description
One Line Summary
Run Prettier on code files to address [Test] Linting build failure.
Details
Motivation
Fix [Test] Linting build failure with beta-2 naming updates.
Manual testing
Ran project after running Prettier to ensure no additional failures.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is