Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Run Prettier #1528

Merged

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Jun 20, 2023

Description

One Line Summary

Run Prettier on code files to address [Test] Linting build failure.

Details

Motivation

Fix [Test] Linting build failure with beta-2 naming updates.

Manual testing

Ran project after running Prettier to ensure no additional failures.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla jennantilla changed the base branch from major_release_5.0.0 to user_model_beta2/rename_events June 20, 2023 18:24
@jennantilla jennantilla changed the base branch from user_model_beta2/rename_events to major_release_5.0.0 June 20, 2023 18:25
@jennantilla jennantilla changed the base branch from major_release_5.0.0 to user_model_beta2/rename_events June 20, 2023 18:38
Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the lint changes LGTM except the migration guide since it is poor at linting tables.

I think we have to manually go through the migration guide, or exclude the migration guide from lint rules.

We can exclude the migration guide from linting but I do like some of the changes it made. So, I think we can accept most of the changes it made on non-table parts, and manually do the table changes ourselves to comply with the lint rules.

"rootDir": "src",
"declaration": true,
"allowSyntheticDefaultImports": true,
"skipLibCheck": true,
"esModuleInterop": true,
"strict": true,
"noUnusedLocals": true,
"noUnusedLocals": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why they removed the last comma here (which I think it should be there), but in other examples, added the last comma. Such as in "src/models/Subscription.ts" they added a comma after Ephemeral 🤷🏻‍♀️

@nan-li nan-li self-requested a review June 30, 2023 20:05
@jennantilla jennantilla merged commit a096ed8 into user_model_beta2/rename_events Jul 24, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants