Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup - iOS misc RCTOneSignal (Needs testing) #1196

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cleanup - iOS misc RCTOneSignal (Needs testing) #1196

wants to merge 4 commits into from

Commits on Apr 10, 2021

  1. Clean up iOS 7 and older check 

    * OneSignal only support iOS 9 and newer
    @jkasten2
    jkasten2 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    97161ef View commit details
    Browse the repository at this point in the history

  2. rm handleRemoteNotificationOpened 

    * This now setup in
RCT_EXPORT_METHOD(setNotificationOpenedHandler) so this is dead code
* rm supporting jsonObjectWithString method as this is now dead code
* rm coldStartOSNotificationOpenedResult as it was never used
    @jkasten2
    jkasten2 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    c8ac1c3 View commit details
    Browse the repository at this point in the history

  3. rm didStartObserving from RCTOneSignal.h 

    * This is used anywhere.
* Not related to RCTOneSignalEventEmitter's _didStartObserving
    @jkasten2
    jkasten2 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    1d41a99 View commit details
    Browse the repository at this point in the history

  4. rm NSNotificationCenter removeObserver 

    * RCTOneSignal never uses NSNotificationCenter,  removeObserver is
dead code
    @jkasten2
    jkasten2 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    41a6193 View commit details
    Browse the repository at this point in the history