Refactor some common special-case settings #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmadler
commented
Nov 29, 2020
| @@ -138,41 +138,32 @@ public static function get_onesignal_settings() { | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
I removed this first comment block as I'm not sure if it's still meaningful. Are these supposed to be caller instructions?
jmadler
commented
Nov 29, 2020
| // Do NOT enable the notify button for existing WordPress sites, since they might have a lot of users | ||
| $onesignal_wp_settings['notifyButton_enable'] = false; | ||
| } | ||
| // These boolean settings are on by default for new installs only, and off by default on plugin upgrades, |
There was a problem hiding this comment.
Am I correct in my understanding here?
jmadler
commented
Nov 29, 2020
| ); | ||
| foreach ($uncustomizedByDefault as $key => $value) { | ||
| if (!array_key_exists($key, $onesignal_wp_settings)) { | ||
| if ( $is_new_user ) { |
There was a problem hiding this comment.
is the array_key_exists/is_new_user dupe test still necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is