Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance OneSignal widget to reflect signup status #220

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Enhance OneSignal widget to reflect signup status #220

wants to merge 14 commits into from

Conversation

davisshaver
Copy link

@davisshaver davisshaver commented Nov 30, 2019 •
edited by sync-by-unito bot

New JS approach based on official docs: https://documentation.onesignal.com/docs/web-push-custom-code-examples#section-custom-link-permission-message

  • Allows for multiple widgets on page
  • Provides new "loading" message while subscription status retrieved
  • Changes message/action based on subscription status
  • Allows unsubscription message to be changed with widget
  • Uses textwidget class for better default styling

This change is Reviewable

@davisshaver davisshaver mentioned this pull request Dec 9, 2019
Open
@rgomezp
Copy link
Contributor

rgomezp commented Dec 9, 2019

Thanks so much for your work on this! Let us know as soon as the PR is ready for review and we'll try to review asap

@davisshaver davisshaver marked this pull request as ready for review December 28, 2019 16:56
@davisshaver
Copy link
Author

Thank you @rgomezp, this is ready for review. I have updated the branch to include the recent changes for VIP.

@rgomezp
Copy link
Contributor

rgomezp commented Nov 28, 2023

The reason this hasn't been merged is due to limited bandwidth and because it still requires testing and approval by WP VIP team.

I don't want to close it so that it doesn't get lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgomezp rgomezp Awaiting requested review from rgomezp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davisshaver @rgomezp