Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for Dev-Dev Environments #1157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Feb 6, 2024

Adjustments for Dev-Dev Environments

Summary

  • Change API port number to 3000 in dev-dev environments
  • Update build script to default to localhost for API origin in dev-dev environments

Description

This PR includes two primary updates to improve the development experience in dev-dev environments.

API Port Configuration
The API port number has been modified to 3000. This aligns with the current usage in our API development environment, ensuring consistency across our development setup.

Build Script Modification
We've made a key change in the build script. Now, it will automatically set the API origin to localhost when in dev-dev environments. This addresses the issue where the system would default to onesignal.com if no API origin was specified. With this update, developers can work more seamlessly, without the need to manually configure the API origin for local development.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Changes were tested in conjunction with the a running local dev server.

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed
    • Changes unrelated to source code

This change is Reviewable

Motivation: the API dev environment uses 3000, not 3001
Motivation: we default to onesignal.com if no API origin is passed in. Thus, we should specify that the api origin should be localhost for dev-dev
@rgomezp rgomezp requested a review from jkasten2 February 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant