[Remove] Old Android Gradle Files from Example project #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr template according to this guide https://github.com/OneSignal/sdk-repo-guidance/blob/main/docs/whate-are-pr-templates.md
[CHANGE] Overwrite project's AndroidManifest if diff
ProjectCapabilityManager will fail to write if the entitlementsPath is absolute instead of relative. This seems to only happen when building for iOS on Windows, and works fine on macOS for some reason.
…nts_path [FIX] Unity Build on Windows Targeting iOS errors on Entitlements file
[FIX] Refresh service extension pod version on each build
[FEATURE] Check EDM4U Version
adding a pr template to the .github folder
These used to be required for our 2.x.x SDK but no longer in our needed in 3.0.0. This has a side effect where EDM4U downloads .aar and .jar files to Assets/plugins/Android so added this to the .gitignore.
There was a problem hiding this comment.
If we're going to change this then we should reset our EDM4U and Unity Android publishing settings to their defaults. We should also not ignore the imported AAR files as that would not be the case in any other repo.
The original intent behind changing the project to use the the mainTemplate.gradle file instead of the imported AARs was to:
- prevent having the AARs in the repo
- make diagnosing gradle issues a little easier
- have the project be ready to build the second it opens
Reviewable status: 0 of 5 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove old Gradle Files from Example project, these were needed in 2.x.x but no longer since 3.0.0.
Details
Motivation
These extra files don't reflect a standard project and create confusion.
Scope
Only effects the example project for Android.
EDM4U resolve change
With these .gradle files removed EDM4U now puts .aar and .jar files into the example project's
Assets/plugins/Android/, a.gitignorechange was also added so build time libraries are not committed.This change is