BadTokenException and WindowLeaked bug fix #2073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow OneSignal#2014 android.view.WindowLeaked:
jkasten2
requested changes
May 3, 2024
There was a problem hiding this comment.
@sooraj-r-pai Thanks for submitting this PR. This PR however does have a side effect of the dialog never showing in these conditions. Ideally we wait until the next Activity is available before show this dialog. Something similar to the code we have in RequestPermissionService.startPrompt() could be done to do this.
The the above is a larger undertaking, so logging as an error would be acceptable, so it is known the dialog was skipped. Use the OneSingal's internal Logging.error method if we go down this path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has fix for
#2014 [Bug]: android.view.WindowManager$BadTokenException - Unable to add window
and
android.view.WindowLeaked:
This change is