[Dev App] Adding some misc buttons for development and testing #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update ApplicationService to more accurately detect when the app goes in/out of focus * Always switch to main thread for RequestPermission calls, to ensure that (1) a suspend occurs and (2) any UI operations happen on the main thread.
* Add ToJsonObject to NotificationClickResult, NotificationAction, and InAppMessageClickResult. * Expose groupedNotifications in INotification
[User Model] Application Focus and Threading
[User Model] Provide serialization mechanism for external classes
* Rebuild new user when an operation indicates the current user is no longer found. * Properly handle all response status codes.
[User Model] Successfully recover from failing operations
…ader [User Model] Add "OneSignal-Subscription-Id" header to requests
* Support transfer of subscription on user create which allows proper transfer even if there is no token. * Allow optIn to drive permission even if already opted in * Align API to native iOS
* On initialization, check for old player_id and build local user as required * New LoginUserFromSubscriptionOperation and execution to support converting a local user to the user that owns a subscription.
…api-align [User Model] Transfer Subscription on user create
[User Model] Support migrating user from SDK 4.x to SDK 5.x
[User Model] Fix broken unit test compilation
[User Model] Add validation logic to add/remove email & sms subscriptions
* Add new logo to example app * Set `SDK-Wrapper` header based on new OneSignalWrapper interface, to be set by wrapper SDKs. * Remove `clickId` and `pageId` from IInAppMessageAction, these should not be public. * Rework IAM dismiss flow so close button will drive click handler. * Drive re-evaluation of IAMs when IInAppMessageManager.paused is set to true. * Change INotificationsManager removeNotification functions to no longer be suspending functions. * Fix issue where notification received callbacks taking longer than 30 seconds would still be waited for.
[User Model] Pre-Beta Fixes
…ified in the params
…d-influences [User Model] Properly set `isUnattributedEnabled` to config when specified in the params
[User Model] Beta Release Prep
…-settable [User Model] Make `sdkVersion` in OneSignalWrapper settable.
[User Model] Expose `INotification.rawPayload`
Release 5.0.0-beta2
…ing permissions. Detection requires persistence to preferences, which allows the addition of INotificationsManager.canRequestPermission.
…instead of try/catch
…ion_lib Fix: Catch IllegalStateException on call to Google's location library
Since isShared now defaults to false, remove early return and add logging to update isShared to true.
- Change log to warn vs. error - Access and save to constant PREFS_OS_LOCATION_SHARED
Fix: Update startGetLocation to only run if location is shared
Add getter for onesignalId and UserStateObserver
Require developers to add ACCESS_COARSE_LOCATION to their AndroidManifest themselves. This is done to avoid the location permission requirement for those who use the com.onesignal:OneSignal package like our wrapper SDKs. This change reverts back to the player model behaviour
Make it clear that developers have to add the access location permission to their AndroidManifest for the location module to work
Remove ACCESS_COARSE_LOCATION permission
Release 5.1.0
Motivation: It is a bit tedious to add buttons to the demo app to facilitate development and testing. Solution: Add 3 buttons that can be used during development and testing. Just modify the buttons to do what you want it to do.
nan-li
requested review from
jkasten2,
emawby,
jinliu9508,
shepherd-l and
jennantilla
jinliu9508
force-pushed
the
user-model/main
branch
3 times, most recently
from
2072eac
to
d73bfc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add 3 buttons to the Dev App that can be used in the development process,
Details
Motivation
Solution:
MainActivityViewModel.javaand look for the buttons namedmiscButton1,miscButton2, andmiscButton3.Scope
Dev App
Testing
Unit testing
None, not needed for dev app
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is