Certificate based authentication for Connect-SafeguardSPS #487
Conversation
| .EXAMPLE | ||
| Get-SafeguardSpsSupportBundle | ||
| #> | ||
| function Get-SafeguardSpsSupportBundle |
There was a problem hiding this comment.
I've only just taken a quick look at this, but why has this Get-SafeguardSpsSupportBundle method been removed?
There was a problem hiding this comment.
It looks like I accidentally removed it from the end somehow, I added it back on the new commit.
Added back the function Get-SafeguardSpsSupportBundle which was accidentaly removed
src/sessionapi.psm1
Outdated
| Disable-SslVerification | ||
| if ($global:PSDefaultParameterValues) { $PSDefaultParameterValues = $global:PSDefaultParameterValues.Clone() } | ||
| } | ||
| write-host $Thumbrint |
There was a problem hiding this comment.
Does this write-host serve a purpose or is it leftover debug code?
| [Parameter(Mandatory=$false)] | ||
| [object]$Parameters, | ||
| [Parameter(Mandatory=$false)] | ||
| [string]$InFile |
There was a problem hiding this comment.
Why is the $OutFile parameter being removed?
|
It appears that one of your commits changed all of the line endings, causing the whole file to appear as changed. The first commit made did not have this problem. I know there is an option in GitHub to ignore white space when looking at a diff, but other general rules and best practices is that any changes should conform to the existing coding styles and rules, including the use of white space. It appears that the original files are only using a Line Feed character. Can you check your text editor and correct the file. |
#486 -> Created an option for my request.