Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo ("Initalize") #2249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CyberShadow
Copy link

No description provided.

@filipw
Copy link
Member

filipw commented Oct 19, 2021

thanks - unfortunately this typo is in the public interface which is published to nuget and it is a breaking change.
However IMHO this is still acceptable change to make, as it should have never been like this in the first place, it's a clear mistake.

@filipw
Copy link
Member

filipw commented Oct 21, 2021

@NTaylorMullen do you guys implement this interface in Razor tooling? would this be a breaking change if we rename this due to a typo?

@NTaylorMullen
Copy link
Collaborator

@filipw thanks for asking. So based on a search of our repo I don't see any reference of Initalize which leads me to think this would be fine. That being said, the assumption there assumes that O# is binding redirecting dlls appropriately so we don't typeload 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants