Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add V2 version of GotoDefinitionService #2168

Merged
merged 7 commits into from May 31, 2021
Merged

Add V2 version of GotoDefinitionService #2168

merged 7 commits into from May 31, 2021

Commits on May 30, 2021

  1. Add V2 version of GotoDefinitionService 

    The V1 GotoDefinitionService can only return one definition for a symbol. This is particularly annoying for partial types, which have multiple locations, and the location the service returns is pretty much never the one I want. The V2 service is very similar, but it uses V2 location models and returns a list of definitions, not a single one.
    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    5726f90 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into find-multiple-symbols

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    e1d8231 View commit details
    Browse the repository at this point in the history

  3. Use V2 definition handler for LSP as well.

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    2e97140 View commit details
    Browse the repository at this point in the history

  4. PR feedback, fix up a translation bug in the Cake code.

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    0cbd0ba View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary setters.

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    560bad9 View commit details
    Browse the repository at this point in the history

  6. Refactor gotodefinition tests to share most via a base class.

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    4d2c47b View commit details
    Browse the repository at this point in the history

  7. Use correct element when translating.

    @333fred
    333fred committed May 30, 2021
    Copy the full SHA
    59cb472 View commit details
    Browse the repository at this point in the history