Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set compilation platform of the project #2135

Merged
merged 5 commits into from Apr 16, 2021

Conversation

filipw
Copy link
Member

@filipw filipw commented Apr 15, 2021

Platform property of the compilation options should be based on the PlatformTarget MSBuild property.

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipw filipw merged commit 2b2c41b into master Apr 16, 2021
@filipw filipw deleted the feature/platformtarget branch April 16, 2021 09:38
@filipw filipw restored the feature/platformtarget branch April 16, 2021 09:38
@filipw filipw deleted the feature/platformtarget branch April 16, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants