fix exception with null sdk version #2058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when the dotnet sdk isn't available in PATH.
|
|
filipw
reviewed
Dec 31, 2020
| @@ -87,7 +87,7 @@ private static HashedString GetProjectId(ProjectLoadedEventArgs args) | |||
|
|
|||
| private static HashedString GetSdkVersion(ProjectLoadedEventArgs args) | |||
| { | |||
| return _tfmAndFileHashingAlgorithm.HashInput(args.SdkVersion.ToString()); | |||
| return _tfmAndFileHashingAlgorithm.HashInput($"{args.SdkVersion}"); | |||
There was a problem hiding this comment.
we could just return a null I think
however, a better question is if we should allow to start without dotnet on the path at all.
There would be other things that will fail without it e.g. auto restore or test adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting errors like:
{"Event":"log","Body":{"LogLevel":"ERROR","Name":"OmniSharp.MSBuild.ProjectLoadListener","Message":"Unexpected exception got thrown from project load listener: System.NullReferenceException: Object reference not set to an instance of an object\n at OmniSharp.MSBuild.ProjectLoadListener.GetSdkVersion (OmniSharp.MSBuild.Notification.ProjectLoadedEventArgs args) [0x0000b] in <7e6cb753aca94549b693616e0e7d1016>:0 \n at OmniSharp.MSBuild.ProjectLoadListener.ProjectLoaded (OmniSharp.MSBuild.Notification.ProjectLoadedEventArgs args) [0x0001a] in <7e6cb753aca94549b693616e0e7d1016>:0 "},"Seq":137,"Type":"event"}This happens when
dotnetisn't available in PATH. Omnisharp runsdotnet --infoand if it fails,SdkVersionends up null.My change is a bit hacky. Perhaps it would be better to propagate the null through to
ProjectConfigurationMessage.SdkVersion? That seems to be the only place it's used, but it might be a breaking protocol change.