Fix gulp serve failed
#61
Open
+63
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web part is incompatible with the module in version 1.3.7, because there a new property is introduced in `IPropertyFieldRichTextBoxProps`
Update state directly is not recommanded, we should use `setState()` to update state
This reverts commit 21f86bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed three issues that makes
gulp servefailure.The issues are:
Error - typescript - node_modules/@microsoft/sp-loader/node_modules/@types/react/index.d.ts(39,25): error TS1005: ',' expected.Reason:
typescriptmodule being used is not compatible with the@types/reactmodule being usedFixed by 49c4679
See also: types/react/index.d.ts(191,27): error TS1005: ',' expected DefinitelyTyped/DefinitelyTyped#17459
Error - typescript - src/webparts/messageBar/MessageBarWebPart.ts(111,49): error TS2345: Argument of type '{ label: string; initialValue: string; inline: false; minHeight: number; mode: string; onProperty...' is not assignable to parameter of type 'IPropertyFieldRichTextBoxProps'.Reason: upstream introduce a new property, with is not compatible with our code.
Fixed by c5808e1
See also: OlivierCC/sp-client-custom-fields@0f53db7
Error - typescript - src/webparts/simplePoll/components/SimplePollWebPartHost.tsx(208,15): error TS2540: Cannot assign to 'selectedValue' because it is a constant or a read-only property.Reason: we should not set state directly.
Fixed by 7bb4de2
See also: State and Lifecycle - React