Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding webp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py #816

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

santokalayil
Copy link

Allowed extensions in opencv read list were ["jpg", "jpeg", "png"]. .webp extension also also can be read by opencv. Therefore adding webp to the allowed_extension list.

Allowed extensions in opencv read list were `["jpg", "jpeg", "png"]`. `.webp` extension also also can be read by opencv. Therefore adding `webp` to the allowed_extension list.
@Pikamander2
Copy link

Is it possible to add BMP and TIFF too? OpenCV appears to support them as well.

@santokalayil
Copy link
Author

Is it possible to add BMP and TIFF too? OpenCV appears to support them as well.

Yes. Let me check them first. if those extensions are supporting. will add them as well.

Allowed extensions in opencv read list were ["jpg", "jpeg", "png"]. webp, bmp, tiff extensions also can be read by opencv. Therefore adding webp to the allowed_extension list.
@santokalayil santokalayil changed the title Adding webp to allowed_extensions list in imageai/Detection/__init__.py Adding webp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py Jun 7, 2023
@santokalayil
Copy link
Author

The extensions tiff, bmp were added also the allowed_extension list for cv2.imread method.

Copy link
Author

@santokalayil santokalayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check once the new changes and approve if these changes are fine.

@santokalayil
Copy link
Author

any updates on this change?

@OlafenwaMoses
Copy link
Owner

@santokalayil can you add test cases for this change by

  • adding sample image files with the added extensions
  • add/update test cases for the added image files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants