Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fish permission #339

Closed
wants to merge 3 commits into from
Closed

Add a fish permission #339

wants to merge 3 commits into from

Conversation

FireML
Copy link
Contributor

@FireML FireML commented May 10, 2024

Adds the ability to lock fish behind a permission.

    Shiny Pickle:
      permission: "emf.shiny_pickle"

This fish can only be caught if the player has the emf.shiny_pickle permission.

It loops over all possible fish until the player has permission, or all fish have been checked.

If the player doesn't have permission for any fish, it prints an error to console:

[10:13:39 INFO]: [EvenMoreFish] [STDOUT] Max: 1
[10:13:39 INFO]: [EvenMoreFish] [STDOUT] Checked: 1
[10:13:39 ERROR]: [EvenMoreFish] Could not determine a fish for FireML. The player doesn't have permission to catch any fish! (See fish.yml)

Copy link
Owner

@Oheers Oheers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, however I think this overlaps with the permission requirement in com.oheers.fish.requirements, or does this work slightly differently and if so it may need renaming for clarity.

@FireML
Copy link
Contributor Author

FireML commented May 11, 2024

oh so it does. i didn't realise it already existed, my bad.

@FireML FireML closed this May 11, 2024
@FireML FireML deleted the fish-permission branch May 11, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants