Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(No card) Fix error building Docker image for Cosmetics Web #483

Merged
merged 2 commits into from Jan 17, 2019

Conversation

DWRendell
Copy link
Contributor

I have no idea why, but I started getting the following error when building cosmetics:

Fetched 698 kB in 2s (340 kB/s)
Reading package lists...
W: GPG error: https://dl.yarnpkg.com/debian stable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 4F77679369475BAA
W: The repository 'https://dl.yarnpkg.com/debian stable InRelease' is not signed.
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  dpkg-dev fakeroot libalgorithm-diff-perl libalgorithm-diff-xs-perl
  libalgorithm-merge-perl libfakeroot
Suggested packages:
  debian-keyring
The following NEW packages will be installed:
  build-essential dpkg-dev fakeroot libalgorithm-diff-perl
  libalgorithm-diff-xs-perl libalgorithm-merge-perl libfakeroot nodejs yarn
0 upgraded, 9 newly installed, 0 to remove and 17 not upgraded.
Need to get 16.2 MB of archives.
After this operation, 71.8 MB of additional disk space will be used.
WARNING: The following packages cannot be authenticated!
  yarn
E: There were unauthenticated packages and -y was used without --allow-unauthenticated
ERROR: Service 'cosmetics-web' failed to build: The command '/bin/sh -c apt-get update && apt-get install -y  build-essential   nodejs   yarn' returned a non-zero code: 100

Adding this space before the backslash fixed it, and it does match this step in MSPSDS now.

I think it might be something to so with the key expiring over the new year: yarnpkg/yarn#4453 If anyone has any ideas why this fixed it please let me know.

Copy link
Contributor

@broder broder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this fixed it because it stopped that line from using the cached image on your machine for that line. I think doing docker-compose build --no-cache would have the same effect?

Still happy to merge this if you want to though.

@DWRendell
Copy link
Contributor Author

I'm guessing this fixed it because it stopped that line from using the cached image on your machine for that line. I think doing docker-compose build --no-cache would have the same effect?

Still happy to merge this if you want to though.

That makes sense. Might as well, it does make the formatting match MSPSDS at least

@jasiekmiko
Copy link
Contributor

Can confirm docker-compose build --no-cache was how we fixed this with Raam last week.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2461

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-17.3%) to 78.774%

Totals Coverage Status
Change from base Build 2457: -17.3%
Covered Lines: 167
Relevant Lines: 212

💛 - Coveralls

@broder broder merged commit 7bdf76f into master Jan 17, 2019
@broder broder deleted the fix-cosmetics-build-error branch January 24, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants