Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All hosts](security) Update NAA article to support a walkthrough #4519
[All hosts](security) Update NAA article to support a walkthrough #4519
Changes from 8 commits
66325bd
8c5ae1d
bc54404
f870a4e
c1e9f56
d81e991
757df1c
228e4a0
8042db1
5eea1b6
41a3d7f
8b409a7
3dfc70f
744e8a5
d90c525
14337b6
24f0145
2510a1f
5b55663
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it really be adapted to any project? Would it apply to the SSO project? To the React project? The latter doesn't have a taskpane.js or taskpane.ts file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work to reword that better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The msalConfig const is only called in the onReady method, so why not declare it there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put all the TODOs here, so they provide a kind of overview of what is going to be done. That's how we do it in other walkthroughs.
Also, there was no TODO 1, so it looks like the numbering is off.