Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook] (multi-select) Add unified manifest support #4428

Merged
merged 4 commits into from May 3, 2024

Conversation

samantharamon
Copy link
Contributor

To be merged during GA of Outlook add-ins with unified manifest.

Copy link
Contributor

Learn Build status updates of commit 8c05e6d:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/item-multi-select.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@Rick-Kirkham Rick-Kirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but with one major concern.

> [!NOTE]
> The item multi-select feature isn't currently supported in the [Unified manifest for Microsoft 365 (preview)](../develop/unified-manifest-overview.md), but the team is working on making this available.
> Item multi-select can also be enabled without setting the "runtimes.actions.multiselect" property to `true` if the "runtimes.actions.supportsNoItemContext" property is set to `true` in the manifest. To learn more, see [Activate your Outlook add-in without the Reading Pane enabled or a message selected](contextless.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is correct, but I wonder if doing this would be a good practice. Since the default for "multiselect" is false, normally the absence of it would imply that it is false. But if users follow the suggestion in this note, they'll have a manifest where "multiselect" is not present but is true. I think this would be misleading and potentially confusing to a developer who is looking at the manifest to troubleshoot some problem. If I'd known what the product team was planning with this property, I'd have argued against this design. But I guess that ship has sailed, so I'd recommend that we just not tell people about this implicit setting of "multiselect" to true. If they always explicitly include it and set it to true when it should be, then their manifest is self-documenting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great point. Thanks for bringing it up. I removed this note.

Copy link
Contributor

Learn Build status updates of commit bfe5312:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/item-multi-select.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 9968f2d:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/item-multi-select.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 39c0ab2:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/item-multi-select.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham marked this pull request as ready for review May 3, 2024 19:53
@Rick-Kirkham Rick-Kirkham merged commit 64b1643 into main May 3, 2024
2 checks passed
@Rick-Kirkham Rick-Kirkham deleted the samramon-multi-select-unified-manifest branch May 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants