Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook] (manifest) document unified manifest for newish features #4338

Merged
merged 6 commits into from May 3, 2024

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Dec 24, 2023

Note to reviewers:

  1. The changes won't be published until GA of unified manifest for Outlook, currently expected in late February.
  2. When users create the initial project using the Outlook quickstart for unified manifest, they will be using the quickstart that is updated to assume that Yo Office has give an option to choose the script type and instructs readers to choose JavaScript..

Copy link
Contributor

Learn Build status updates of commit ffe4ab1:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit a60381f:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 090e02c:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham marked this pull request as draft December 28, 2023 01:48
docs/outlook/contextless.md Outdated Show resolved Hide resolved
docs/outlook/contextless.md Outdated Show resolved Hide resolved
docs/outlook/contextless.md Outdated Show resolved Hide resolved
Comment on lines +64 to +66
"pinnable": true,
"supportsNoItemContext": true,
"multiselect": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to explicitly configure "pinnable" and "multiselect"? From what I understand, these features are automatically enabled when "supportsNoItemContext" is set to true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not mandatory to include them when "supportsNoItemContext" is true, but since the default for "pinnable" and "multiselect" (when they are not present) is false, I think it is misleading/confusing to leave them out in circumstances where they are NOT going to have their default values.

Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit 358a9fa:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 70d4b39:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f2a1ca4:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/contextless.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham marked this pull request as ready for review May 3, 2024 19:50
@Rick-Kirkham Rick-Kirkham merged commit 62b8043 into main May 3, 2024
2 checks passed
@Rick-Kirkham Rick-Kirkham deleted the unified-manifest-support-newer-articles branch May 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants