New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outlook] (manifest) document unified manifest for newish features #4338
Conversation
Learn Build status updates of commit ffe4ab1: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit a60381f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 090e02c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
"pinnable": true, | ||
"supportsNoItemContext": true, | ||
"multiselect": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to explicitly configure "pinnable" and "multiselect"? From what I understand, these features are automatically enabled when "supportsNoItemContext" is set to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not mandatory to include them when "supportsNoItemContext" is true, but since the default for "pinnable" and "multiselect" (when they are not present) is false, I think it is misleading/confusing to leave them out in circumstances where they are NOT going to have their default values.
Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com>
Learn Build status updates of commit 358a9fa: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 70d4b39: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit f2a1ca4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Note to reviewers: