Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook] (manifest) mobile support in unified manifest #4334

Merged
merged 20 commits into from May 3, 2024

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Dec 22, 2023

Note to reviewers:

For the files, online-meeting.md, I reversed the order of the tabs for XML manifest and unified manifest, so that the latter is now the detault tab. But his makes it appear in the diff that much more has changed than actually has. The only significant changes are lines 157 - 248.

THIS PR IS SET TO "DRAFT" TO ENSURE THAT IT ISN'T MERGED UNTIL GA OF OUTLOOK ADD-INS WITH UNIFIED MANIFEST. CURRENTLY SCHEDULED FOR LATE FEBRUARY, 2023.

@Rick-Kirkham Rick-Kirkham marked this pull request as draft December 22, 2023 01:55
Copy link
Contributor

Learn Build status updates of commit 5ef2b13:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/outlook/online-meeting.md ⚠️Warning View Details

docs/outlook/online-meeting.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '02/28/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit a7c6375:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/outlook/online-meeting.md ⚠️Warning View Details
docs/outlook/outlook-mobile-addins.md ⚠️Warning View Details

docs/outlook/online-meeting.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '02/28/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

docs/outlook/outlook-mobile-addins.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '02/28/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.
  • Line 57, Column 37: [Warning: disallowed-html-tag - See documentation] HTML tag 'MobileFormFactor' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 6a7599c:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/outlook/online-meeting.md ⚠️Warning View Details
docs/outlook/outlook-mobile-addins.md ⚠️Warning View Details

docs/outlook/online-meeting.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '02/28/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

docs/outlook/outlook-mobile-addins.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '02/28/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 05afd0e:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/outlook/online-meeting.md ⚠️Warning View Details
docs/outlook/outlook-mobile-addins.md ⚠️Warning View Details

docs/outlook/online-meeting.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '01/22/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

docs/outlook/outlook-mobile-addins.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '01/22/2024'. Must be a date in format M/D/YYYY, no more than 30 days from today.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 113b2ed:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 849e87c:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 626a88d:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 32dedde:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 3da74e6:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 79dcef2:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/mobile-event-based.md Outdated Show resolved Hide resolved
docs/outlook/outlook-mobile-addins.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit 662e523:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 879bbad:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 79ca2ad:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 6838bf3:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 870b47c:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@samantharamon samantharamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the "customMobileRibbonGroups" array.

docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/add-mobile-support.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
docs/outlook/online-meeting.md Outdated Show resolved Hide resolved
docs/outlook/outlook-mobile-addins.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 7ab781d:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit a9a2b5c:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/add-mobile-support.md ✅Succeeded View
docs/outlook/mobile-event-based.md ✅Succeeded View
docs/outlook/online-meeting.md ✅Succeeded View
docs/outlook/outlook-mobile-addins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham marked this pull request as ready for review May 3, 2024 19:49
@Rick-Kirkham Rick-Kirkham merged commit 9d2a1af into main May 3, 2024
2 checks passed
@Rick-Kirkham Rick-Kirkham deleted the unified-manifest-support-outlook-mobile branch May 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants