Add ability for teams test app to remember scroll position on reload #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const handleScroll = throttle(() => { | ||
| const scrollPosition = window.scrollY; | ||
| sessionStorage.setItem('iframeScrollPosition', JSON.stringify(scrollPosition)); | ||
| console.log('scrolling'); |
TrevorJoelHarris
requested changes
Apr 23, 2024
… names conflict (#2280) * update * update * update
* Split iOS E2E Testing pipeline to two * update * update * update * update * update * update * update
* Removed beta tage on Pages.currentApp namespace and APIs * Added changefile * Update change/@microsoft-teams-js-51421b73-089f-43de-9076-75563e1f064c.json --------- Co-authored-by: Trevor Harris <trharris@microsoft.com>
…yerPort (#2277) Update Message Channel capability to support sub capabilities, add data layer capability with getDataLayerPort --------- Co-authored-by: sumathin <sum_nat1@yahoo.com> Co-authored-by: sumathin <sunatara@microsoft.com> Co-authored-by: Trevor Harris <trharris@microsoft.com>
* backed out all exported const enums
* add sdf release yaml --------- Co-authored-by: jadahiya-MSFT <95651173+jadahiya-MSFT@users.noreply.github.com> Co-authored-by: Trevor Harris <trharris@microsoft.com>
* Update comment * Update changefile
…onnector Plugins (#2272) * Adding PPC auth * Adding PPCauth UTs * adding change file * Resolving comments * Resolving comments * Modify hasScriptTags function to handle encoded Input * Modify hasScriptTags function to handle encoded Input * updating default input * Modify hasScriptTags function to handle encoded Input * adding telemetry tag for ppc auth * Removing pluginId and adding unit tests * Changing url to string before passign to psotmessage * Removing regualr expression for html entities * Removing regualr expression for html entities * Modifying comments * Modifying comments * Resolving comments * Resolving comments --------- Co-authored-by: Lakhveer Kaur <lakhveerkaur@microsoft.com> Co-authored-by: Erin <erinha@microsoft.com>
* Webstorage becomes capability * Update webstorage in test app * Update webstorage test json * Add changefile * Test updates * Test updates * Final test updates * Helpful util * Empty json test file
* Not blank, but almost blank * Updated
* Publish android artifacts * Use 1ES publishing steps * task names * Use updated artifact location * Add job attempt
* Added in new valid domains for Copilot Chat * Added in changefile --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
* Restrict authentication.authenticate to only accept https urls * Create @microsoft-teams-js-40968a44-8220-4162-a289-038e99f5bee3.json * Updated based on PR feedback * Updated to use new validation functions and added(?) support for URL encoded strings * abstract out the auth code's use of the a tag and then add tests to make sure URL encoded partial urls work correctly * Re-order imports * Updated based on PR feedback --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
* Fix incorrect API telemetry label for Pages_NavigateToApp API * update * Update @microsoft-teams-js-d2040181-a9a1-42d2-9080-35acb3a380cd.json --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
* Update sdf-release.yml for Azure Pipelines * Update sdf-release.yml for Azure Pipelines
Co-authored-by: sthousto <sthousto@microsoft.com_odspmdb> Co-authored-by: Trevor Harris <trharris@microsoft.com>
* Update .npmrc location * Changefile * Update @microsoft-teams-js-b63da2d9-3e02-4b83-9664-78aa8f49c713.json * use new scripts for onebranch pipelines --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
323340276-5cd05365-6e54-4eee-bba2-38208f7da82d.mp4
Description
Our test app is very large and sometimes we're using it to manually test a specific capability which requires scrolling or ctrl-F to the right spot every reload. This change optionally sets the scroll position of the window and stores it in session storage to enable returning to the same spot after a reload. I've also added a scroll-to-top button.
Main changes in the PR:
Validation
Validation performed:
See attached video