Trharris/authenticate https #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydogandjiev
previously approved these changes
Apr 17, 2024
AE-MS
reviewed
Apr 17, 2024
change/@microsoft-teams-js-40968a44-8220-4162-a289-038e99f5bee3.json
Outdated
Show resolved
Hide resolved
AE-MS
reviewed
Apr 17, 2024
erinha
reviewed
Apr 17, 2024
erinha
reviewed
Apr 17, 2024
erinha
reviewed
Apr 17, 2024
erinha
reviewed
Apr 17, 2024
…ake sure URL encoded partial urls work correctly
…eDev/microsoft-teams-library-js into trharris/authenticateHttps
erinha
reviewed
Apr 26, 2024
erinha
previously approved these changes
Apr 26, 2024
AE-MS
reviewed
Apr 26, 2024
maglims
reviewed
Apr 26, 2024
AE-MS
reviewed
Apr 26, 2024
AE-MS
reviewed
Apr 26, 2024
maglims
approved these changes
Apr 27, 2024
ndangudubiyyam
approved these changes
Apr 27, 2024
erinha
approved these changes
Apr 29, 2024
alexneyman-MSFT
pushed a commit
that referenced
this pull request
May 6, 2024
* Restrict authentication.authenticate to only accept https urls * Create @microsoft-teams-js-40968a44-8220-4162-a289-038e99f5bee3.json * Updated based on PR feedback * Updated to use new validation functions and added(?) support for URL encoded strings * abstract out the auth code's use of the a tag and then add tests to make sure URL encoded partial urls work correctly * Re-order imports * Updated based on PR feedback --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
alexneyman-MSFT
pushed a commit
that referenced
this pull request
May 9, 2024
* Restrict authentication.authenticate to only accept https urls * Create @microsoft-teams-js-40968a44-8220-4162-a289-038e99f5bee3.json * Updated based on PR feedback * Updated to use new validation functions and added(?) support for URL encoded strings * abstract out the auth code's use of the a tag and then add tests to make sure URL encoded partial urls work correctly * Re-order imports * Updated based on PR feedback --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
authentication.authenticatewill now throw an error if any url that is not https is passed into it. This should have already been the case and it not being enforced in TeamsJS is a bug.Main changes in the PR:
authentication.authenticateto throw an error if a non-https url is passed to itauthentication.authenticateto make it clear that there were only 2 case: HostClientType.web || !HostClientType.webutils.initializeWithContext(a test only function) where many people were passing in an undefined HostClientType which can cause various weirdness during test execution. That function now has a default HostClientType value if one is not passed in.Validation
Validation performed:
Unit Tests added:
Yes
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes