New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Task 8700131] Implementing pages.responseButton sub-capabilities #2157
base: main
Are you sure you want to change the base?
Conversation
This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required. |
change/@microsoft-teams-js-110c93c8-66d6-41f2-93ac-184f15791273.json
Outdated
Show resolved
Hide resolved
* | ||
* @beta | ||
*/ | ||
export function responseButtonEventHandler(appEventHandler: handlerFunctionType): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no data the host has to pass down to the app developer when this handler is triggered? For example, if the response button is a button with a dropdown that presents multiple options (forward, replyAll, etc.) do you need to make an enum or something similar available here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember from earlier discussion(like a year ago) we did not to want to maintain a list of enums (like: reply, replyall, forward), due to the reason that if hubs decide to add more dropdown options, we will need to add to this list and needs SDK changes. So, it is hard to scale and maintain in the long term.
If we want to allow developers know which button got clicked, and able to handle different logic based on which button got clicked. That sounds good to me. My only ask is that developer don't need to register 3 handlers for 3 items in the same dropdown item if they share the same handler logic.
700ee2f
to
1a235c2
Compare
…3.json Co-authored-by: Trevor Harris <trharris@microsoft.com>
Co-authored-by: Trevor Harris <trharris@microsoft.com>
4c8d65a
to
86a313d
Compare
Co-authored-by: Trevor Harris <trharris@microsoft.com>
86a313d
to
19bb24d
Compare
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
<Yes/No>
End-to-end tests added:
<Yes/No>
Additional Requirements
Change file added:
<Yes/No>
Related PRs:
Next/remaining steps:
Screenshots: