Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irenewang/typedocsupdate #2072

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Irenewang/typedocsupdate #2072

wants to merge 14 commits into from

Conversation

irenewang101
Copy link

For more information about how to contribute to this repo, visit this page.

Description

Update Typedocs for Action related fields. Add more description.

Main changes in the PR:

  1. interfaces.ts Content Action related fields

Validation

Validation performed:

N/A

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

No

End-to-end tests added:

No

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

No

Related PRs:

n/a

Next/remaining steps:

n/a

Screenshots:

n/a

@irenewang101 irenewang101 requested a review from a team as a code owner December 1, 2023 22:00
@AE-MS
Copy link
Contributor

AE-MS commented Dec 1, 2023

{

Can you remove this file from your change? Since we use pnpm as the package manager and not npm, this file is not necessary and should only be generated by npm


Refers to: package-lock.json:1 in 711baed. [](commit_id = 711baed, deletion_comment = False)

@AE-MS
Copy link
Contributor

AE-MS commented Dec 1, 2023

Thanks for helping to improve our documentation!

@AE-MS
Copy link
Contributor

AE-MS commented Dec 1, 2023

{

I will look into restricting npm usage in the repo to make it easier to guide people to the right package manager in the future.


In reply to: 1836927729


Refers to: package-lock.json:1 in 711baed. [](commit_id = 711baed, deletion_comment = False)

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the updates Aaron and I asked for and then you can check in

irenewang101 and others added 2 commits March 8, 2024 15:20
Co-authored-by: Trevor Harris <trharris@microsoft.com>
…5.json

Co-authored-by: Trevor Harris <trharris@microsoft.com>
Copy link
Author

@irenewang101 irenewang101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed comments based on review.

@TrevorJoelHarris TrevorJoelHarris enabled auto-merge (squash) March 8, 2024 23:26
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants