docs: Update package.nls.json #11277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supkasar
requested review from
timngmsft,
sffamily and
therealjohn
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11277 +/- ##
==========================================
+ Coverage 87.36% 87.42% +0.06%
==========================================
Files 463 463
Lines 28133 28197 +64
Branches 5637 5567 -70
==========================================
+ Hits 24579 24652 +73
+ Misses 1778 1771 -7
+ Partials 1776 1774 -2 |
sffamily
reviewed
Apr 8, 2024
| @@ -406,35 +406,35 @@ | |||
| "core.createProjectQuestion.officeXMLAddin.taskpane.detail": "Customize the Ribbon with a button and create a dashboard in the Task Pane", | |||
| "core.createProjectQuestion.officeXMLAddin.manifestOnly.title": "Add-in Project With only Manifest File", | |||
| "core.createProjectQuestion.officeXMLAddin.manifestOnly.detail": "Create an add-in project that includes only the manifest file", | |||
| "core.aiAssistantBotOption.label": "AI Assistant Bot", | |||
| "core.aiAssistantBotOption.detail": "A custom AI assistant bot in Teams using Teams AI library and OpenAI Assistants API", | |||
| "core.aiAssistantBotOption.label": "AI Agent Bot", | |||
There was a problem hiding this comment.
This might be an OpenAI specific term, "AI Assistant". Can check with dev or PM Junjie to confirm.
There was a problem hiding this comment.
I checked with Junjie. We've changed 'AI Assistant' to 'AI Agent'. Updated the title case. Thanks.
| "core.aiAssistantBotOption.label": "AI Assistant Bot", | ||
| "core.aiAssistantBotOption.detail": "A custom AI assistant bot in Teams using Teams AI library and OpenAI Assistants API", | ||
| "core.aiAssistantBotOption.label": "AI Agent Bot", | ||
| "core.aiAssistantBotOption.detail": "A custom AI agent bot in Teams using Teams AI library and OpenAI Assistants API", |
There was a problem hiding this comment.
same as above. If this is a specific term, 'assistant' needs to be capitalized.
sffamily
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.