New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug 27332508: disable auto install dependencies for manifest-only office add-in #11234
Open
richard6094
wants to merge
9
commits into
OfficeDev:dev
Choose a base branch
from
richard6094:fix/27332508
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanwenhe
reviewed
Mar 29, 2024
richard6094
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms,
tecton,
jayzhang,
xzf0587 and
LongOddCode
as code owners
April 24, 2024 09:52
jayzhang
previously approved these changes
Apr 29, 2024
@@ -751,7 +751,7 @@ | |||
{ | |||
"command": "fx-extension.localdebug", | |||
"title": "%teamstoolkit.commands.localDebug.title%", | |||
"enablement": "!fx-extension.commandLocked", | |||
"enablement": "!fx-extension.commandLocked && !fx-extension.isOfficeAddIn || fx-extension.isOfficeAddIn && !fx-extension.isManifestOnlyOfficeAddIn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the command can only be enabled when command unlocked
HuihuiWu-Microsoft
previously approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: bug 27332508: disable auto install dependencies for manifest-only office add-in