Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 1 - Implement New toolkit version csharp samples. #1238

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Harikrishnan-MSFT
Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT commented Apr 18, 2024

Sample List -

1. tab-personal/mvc-csharp
2. tab-sso/csharp

<PropertyGroup Label="Globals">
<ProjectGuid>42a0237c-30e0-42ae-b6ed-50f318517e77</ProjectGuid>
</PropertyGroup>
<ItemGroup>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ItemGroup is unnecessary and can be deleted, but it doesn't block usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<ItemGroup>
<None Include="appPackage\color.png" />
<None Include="appPackage\manifest.json" />
<None Include="appPackage\outline.png" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ItemGroup is unnecessary and can be deleted, but it doesn't block usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Harikrishnan-MSFT Harikrishnan-MSFT added the DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants