Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill Tentacle-Deployment tests #149

Merged
merged 5 commits into from May 12, 2024
Merged

Backfill Tentacle-Deployment tests #149

merged 5 commits into from May 12, 2024

Conversation

flin-8
Copy link
Contributor

@flin-8 flin-8 commented May 9, 2024 •
edited

[sc-70686]
This PR backfills some missing tests for the Tentacle deployment & the server-auth secret.

As part of writing these tests we discovered that really long agent names don't get truncated correctly - that will fixed later.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 9, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0ae581d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

flin-8
flin-8 commented May 9, 2024
View reviewed changes
charts/kubernetes-agent/tests/tentacle-deployment_test.yaml Outdated
asserts:
- equal:
path: metadata.name
value: thisisaverylongstring34087236548972364802367y408923604872341234-tentacle
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@APErebus is the name meant to be shorter than 63 chars?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should automatically truncate it yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've been more specific - do we expect the whole name to be truncated to 63 chars? right now we truncate then add -tentacle to the name (which brings it over 63 chars)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo, interesting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This potential bug is covered by https://app.shortcut.com/octopusdeploy/story/78448/long-target-name-doesn-t-install

flin-8
flin-8 commented May 10, 2024
View reviewed changes
charts/kubernetes-agent/tests/tentacle-server-auth-secret_test.yaml
- equal:
path: data.bearer-token
value: ZmthZGpzZ2Zqa2FldXd5Z2ZrdXd5YWZndTNnd2ZrdWEzNndnZnUzd2drdWphZmdoag==
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call base64enc from in here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know :|

@flin-8 flin-8 changed the title fsdfsd Backfill Tentacle-Deployment tests May 10, 2024
@flin-8 flin-8 self-assigned this May 10, 2024
@flin-8 flin-8 marked this pull request as ready for review May 10, 2024 01:42
@flin-8
Merge remote-tracking branch 'origin/main' into frank/tests
61ccb7b 
# Conflicts:
#	charts/kubernetes-agent/tests/tentacle-container-env-vars_test.yaml
#	charts/kubernetes-agent/tests/tentacle-deployment_test.yaml
@flin-8
fds
0ae581d
APErebus
APErebus approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@APErebus APErebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! Thanks @flin-8

@flin-8 flin-8 merged commit 8707f58 into main May 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APErebus APErebus APErebus approved these changes

Assignees

@flin-8 flin-8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flin-8 @APErebus