Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for bundled tools #2292

Merged
merged 7 commits into from May 13, 2024

Conversation

eddymoulton
Copy link
Contributor

@eddymoulton eddymoulton commented May 10, 2024

Posting a notice in our documentation as part of the deprecation plan for bundled tools [internal link]

[sc-74658]

image

### Bundled Tools
Command line tools for AWS, Azure and Terraform have been included with Octopus Deploy as a convenience mechanism for some time. The provided versions of these tools are now out of date and won't be updated.

As of `2024.2`, deployment steps will no longer be able to use the bundled tools and they will be removed entirely in `2025.1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As of `2024.2`, deployment steps will no longer be able to use the bundled tools and they will be removed entirely in `2025.1`.
As of `2024.2`, deployment steps will no longer be able to use the bundled tools, which will be removed in `2025.1`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phase doesn't seem clear, if it's not removed until 2025.1, what does it mean to say it can't be used in 2024.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it to explicitly mention that they won't be able to be configured, that makes better sense, yes?

Copy link
Contributor

@steve-fenton-octopus steve-fenton-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of suggested wording changes for you to decide on.

Copy link
Contributor

@zentron zentron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about phrasing.

### Bundled Tools
Command line tools for AWS, Azure and Terraform have been included with Octopus Deploy as a convenience mechanism for some time. The provided versions of these tools are now out of date and won't be updated.

As of `2024.2`, deployment steps will no longer be able to use the bundled tools and they will be removed entirely in `2025.1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phase doesn't seem clear, if it's not removed until 2025.1, what does it mean to say it can't be used in 2024.2?

eddymoulton and others added 2 commits May 13, 2024 08:51
Co-authored-by: Steve Fenton <99181436+steve-fenton-octopus@users.noreply.github.com>
@eddymoulton eddymoulton requested a review from zentron May 12, 2024 23:01
Co-authored-by: Mark Coafield <46470837+MissedTheMark@users.noreply.github.com>
Copy link
Contributor

@MissedTheMark MissedTheMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MissedTheMark MissedTheMark dismissed zentron’s stale review May 13, 2024 01:17

Requested change has been made.

@MissedTheMark MissedTheMark merged commit 06e849f into main May 13, 2024
3 of 4 checks passed
@MissedTheMark MissedTheMark deleted the em/add-deprecation-notice-for-bundled-tools branch May 13, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants