New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external feed trigger examples #2250
Conversation
Looks good to me! |
@@ -82,31 +84,45 @@ To configure an inline YAML source, select the `Inline YAML` as your YAML Source | |||
This is **not** the recommended approach for advanced cases as it does not allow for version management unless you are using it in conjunction with [Config As Code](/docs/projects/version-control). | |||
::: | |||
|
|||
## Referencing packages | |||
|
|||
Container images can be selected as **[Referenced Packages](/docs/deployments/custom-scripts/run-a-script-step#referencing-packages)** to automatically generate variables referring to the image name and tag that can be substituted in your manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding something here to note that the image doesn't have to be downloaded for this to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna leave this as is, I don't think anything implies this will or won't download the image and the information likely belongs elsewhere.
I'm pretty sure the UI says it won't be downloaded somewhere too, so I'm not concerned.
A Helm chart deployment like this is simple with Octopus Deploy. | ||
|
||
1. Start with the **Deploy a Helm chart** step | ||
2. Link it to the required Kubernetes clusters via target tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add a link to the target tag page, given that they've recently been renamed from roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of very minor comments, LGTM generally 👍
Adds additional docs to help users choose external feed triggers for their application.
I've added fairly minimal sections in existing kubernetes deployment pages to reference external feed triggers and their use cases + a whole new page to cover automatically updating Helm charts that you don't control.
Update to main external triggers page
Update to deploy raw yaml
Update to deploy Helm
Automatically tracking third party helm charts
[sc-75182]