Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating C# scripts and references from ScriptCS to dotnet script #2035

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

IsaacCalligeros95
Copy link
Contributor

This updates references to ScriptCS and example usage to bring the docs in line with the dotnet-script changes. As this is a 2023.4 change it may make more sense to call out each of the individual scripting libraries rather than just update in place as I've done here. The migration is highlighted in the blog post with recent changes here OctopusDeploy/blog#1077

@IsaacCalligeros95 IsaacCalligeros95 changed the title Updating Dotnet Script tests Updating C# scripts and references from ScriptCS to dotnet script Oct 11, 2023
@steve-fenton-octopus
Copy link
Contributor

@IsaacCalligeros95 I've merged in changes to resolve conflicts with our new spelling checks, which occur for each PR. Please merge when you're ready (I guess this is waiting for a release?)

Copy link
Contributor

@steve-fenton-octopus steve-fenton-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacCalligeros95
Copy link
Contributor Author

@steve-fenton-octopus Thanks Steve, this one will probably be sitting for a while longer, there's a couple of changes to go out and there will be a transition period between the old C# scripting and the new. I'm planning on merging this when most customers have migrated to the newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants