Can we default to pwsh? #829
Draft
+155
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysparry
reviewed
Mar 12, 2024
|
|
||
| return powerShellPath; | ||
| var powerShellCore = new PowerShellCore(); | ||
| if (powerShellCore.PowerShellCoreExists) |
There was a problem hiding this comment.
If we were to do this, we would probably need some sort of configuration to disable/enable.
Also, is it sufficient to find PowerShell core? In the change for the hardening script the branching logic seems to only switch for PowerShell core >= 7.3. Do we need to know the version of PowerShell core?
There was a problem hiding this comment.
The 7.3 check is to work around a change they made to not load the security stuff - PowerShell/PowerShell#18896
Ironically, it was designed to speed up powershell :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
PowerShell.exeis very slow.Results
Can we speed it up by using
pwshinstead?How to review this PR
Quality ✔️
Pre-requisites