Sast/remove unobserved exception polly #575
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeButters
commented
Aug 30, 2023
| return await timeoutPolicy.ExecuteAsync(action, ct).ConfigureAwait(false); | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
@nathanwoctopusdeploy would something like this work? or does the timeoutPolicy need to see an exception? The retry policy should still see an exception.
|
This pull request has been linked to Shortcut Story #58194: Bug: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. |
LukeButters
changed the base branch from
main
to
sast/remove-unobserved-exception
LukeButters
changed the base branch from
main
to
MissedTheMark/enh/signHardenInstallDirScript
LukeButters
changed the base branch from
MissedTheMark/enh/signHardenInstallDirScript
to
main
LukeButters
force-pushed
the
sast/remove-unobserved-exception-polly
branch
from
e237729
to
ed6cddb
Compare
|
@nathanwoctopusdeploy This works, but I am not sure if it is too nasty. I will leave it with you to decide if it ought to go in or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
[SC-58194]
Fixes a unobserved exception caused by polly walking away from requests.
How to review this PR
Quality ✔️
Pre-requisites