Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alixk/dont hardcode ssl versions #517

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

evolutionise
Copy link
Contributor

Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.

Background

Results

Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)

Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)

See How we use GitHub Issues (including this flowchart

Before

Before

After

After

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

… OS. By specifying the SSL versions, we trample over any operating system settings.

For example, even if FIPS is enabled on RHEL, setting the accepted SSL versions means Tentacle will violate those policies and only use the specified versions.
This reverts commit 6efce979b11d35a04bd8ef033ff069b25be0ad71.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant