Add bidirectional tests #607
Conversation
zentron
force-pushed
the
robe/experiment_bidirectional
branch
from
aa9bf68
to
6431b54
Compare
| await Task.WhenAll(t1, t2); | ||
| sw.Stop(); | ||
|
|
||
| sw.ElapsedMilliseconds.Should().BeLessThan(await t1 + await t2); |
There was a problem hiding this comment.
It may be worth replacing the timing to test concurrency by using a "do some action service" and having that action service wait until both requests are in flight before returning.
The tests are run in parallel so the load tends to cause tests with timings to occasionally fail. Sometimes we make those tests run as non parallel but that just means it takes longer to run the tests :(
There was a problem hiding this comment.
have converted the quick POC hack towards something that is hopefully more reliable
| { | ||
| await SetupBiDirectionalClients(async (octopusEchoClient, tentacleEchoClient) => | ||
| { | ||
| var t1 = Task.Run(async () => await RunEchoTask(octopusEchoClient)).WithTimeout(TimeSpan.FromSeconds(5)); |
There was a problem hiding this comment.
What is the intent of the timeout? The base class should be providing a timeout on the test if the concern is this will run forever.
There was a problem hiding this comment.
👍 I've update the timeout limits for use in the test,
| await SetupBiDirectionalPollingClients(async (clientServiceA, clientServiceB) => | ||
| { | ||
| MyEchoService.SharedState = 0; | ||
| var taskA = clientServiceA.BlockWaitingForSharedStateIncrementAsync().WithCancellation(CancellationToken); |
There was a problem hiding this comment.
This should prevent random race conditions when we run the tests in parallel thanks!
Simple test confirming once a connection is established the service messaging layer is bi-directional