Wrapped gcode filepath in analysis.py with quotes. #5009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket - Not applicable
devel
branch if it's a completelynew feature, or
maintenance
if it's a bug fix or improvement ofexisting functionality for the current stable version (no PRs
against
master
or anything else please)(no PRs from your version of
master
,maintenance
, ordevel
please), e.g.
dev/my_new_feature
orfix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less
source files, not the.css
files (those are generatedwith
lessc
) - Not applicablehave added unit tests
nothing broke
AUTHORS.md
file :)What does this PR do and why is it necessary?
Fixing issue #5008.
How was it tested? How can it be tested by the reviewer?
I monkeypatched my installation of octoprint.
The file
/octoprint/octoprint/uploads/.metadata.json
is now correctly modified.Before fix
After fix
Any background context you want to provide?
Plugins like dashboard are depending on the parsed metadata generated like "maxZ".
This lead me here.
Further notes
I failed to run the unit tests via pytest even without my changes. Any help in this department would be great.
What I did:
python setup.py install
pytest .\tests\
I know, python 3.12 breaks a lot of dependencies, but as it is allowed in setup.py (
PYTHON_REQUIRES = ">=3.7, <3.13"
) I went with it. The error i am getting is this one repeating:Edit 1:
I uninstalled my python 3.12 installation and reinstalled python 3.10.11.
Afterwards my unit tests passed successfully. Seems my python 3.12 version has been corrupted.