Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ExcpHandling for BambuStudio and filament diameter #4972

Closed
wants to merge 1 commit into from

Conversation

NilsRo
Copy link
Contributor

@NilsRo NilsRo commented Mar 19, 2024

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance, or devel
    please), e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated
    with lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

BambuStudio Testfile
BBS-Support_top_PLA_36m30s.zip

What does this PR do and why is it necessary?

Added exception handling and new separator for filament diameter parsing

How was it tested? How can it be tested by the reviewer?

Uploading and running estimator for file provided

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

image

Further notes

@github-actions github-actions bot added targets maintenance The PR targets the maintenance branch needs some work There are some things to do before this PR can be merged labels Mar 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic PR Validation failed

There were one or more problems detected with this PR:

  • The PR's source branch master is among the forbidden source branches: master, maintenance, devel, staging/bugfix, staging/maintenance, staging/devel. Please always create PRs from a custom branch in your repository to avoid accidental commits making it into your PR.

Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!

I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.

@NilsRo NilsRo closed this Mar 19, 2024
@foosel
Copy link
Member

foosel commented Mar 20, 2024

One step ahead of you 😂

f4fbe91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs some work There are some things to do before this PR can be merged targets maintenance The PR targets the maintenance branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants