Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump websocket-client to version 1.5.3 to 1.6.1 #4960

Closed

Conversation

QuinnDamerell
Copy link
Contributor

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance, or devel
    please), e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated
    with lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

Bumps the WebSocket lib used to 1.6.1, which fixes a bad dead lock in the lib but is still compatible with PY 3.7.

How was it tested? How can it be tested by the reviewer?

I built OctoPrint and it ran with no problem.

Any background context you want to provide?

From our discussion in #4957

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@github-actions github-actions bot added targets devel The PR targets the devel branch approved Issue has been approved by the bot or manually for further processing labels Feb 25, 2024
@foosel
Copy link
Member

foosel commented Mar 12, 2024

Closing this as it got superseded by 8a9478c against staging/maintenance for 1.10.0rc3.

@foosel foosel closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue has been approved by the bot or manually for further processing targets devel The PR targets the devel branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants