⬆️ Bump websocket-client to version 1.5.3 to 1.6.1 #4960
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
devel
branch if it's a completelynew feature, or
maintenance
if it's a bug fix or improvement ofexisting functionality for the current stable version (no PRs
against
master
or anything else please)(no PRs from your version of
master
,maintenance
, ordevel
please), e.g.
dev/my_new_feature
orfix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less
source files, not the.css
files (those are generatedwith
lessc
)have added unit tests
nothing broke
AUTHORS.md
file :)What does this PR do and why is it necessary?
Bumps the WebSocket lib used to 1.6.1, which fixes a bad dead lock in the lib but is still compatible with PY 3.7.
How was it tested? How can it be tested by the reviewer?
I built OctoPrint and it ran with no problem.
Any background context you want to provide?
From our discussion in #4957
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes