Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track printer profile information #4847

Open
wants to merge 1 commit into
base: maintenance
Choose a base branch
from

Conversation

kantlivelong
Copy link
Contributor

What does this PR do and why is it necessary?

This PR adds printer profile information to anonymous tracking. This can be useful to determine what features/changes to focus on.

How was it tested? How can it be tested by the reviewer?

This was locally tested to ensure the data is compiled and shipped. Data ingestion rules may need to be adjusted to accept the traffic and the dashboard will need to be updated to make use of the data.

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

Right now the primary reason to gather this info is to see how profiles are used. Initially I think it would be worthwhile to display a profile count as a pie chart in data.octoprint.org

@kantlivelong kantlivelong changed the title ✨ Track printer profile information Track printer profile information Jul 7, 2023
@github-actions github-actions bot added targets maintenance The PR targets the maintenance branch approved Issue has been approved by the bot or manually for further processing labels Jul 7, 2023
@huminlian
Copy link

Good request. Can I ask someone to develop a Plugin that can auto-set the 3d printer filament setting like TPU filament and ABS filament?

@kantlivelong
Copy link
Contributor Author

@huminlian What a great way to make people dislike you!

Copy link
Member

@foosel foosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line comment

for k in ["id", "name", "model"]:
# Scrub these out since they could be identifiable information
profile.pop(k)
args["printer_profile"] = profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will need a further deep dive to be flattened. We cannot push hierarchical data like this over to the tracking subsystem, it will end up as one repr string, completely unsearchable or otherwise usable.

I suggest we concentrate on some key infos like extruder count, bed size, presence of heated bed and heated chamber?

@foosel foosel added the needs some work There are some things to do before this PR can be merged label Oct 2, 2023
@kantlivelong
Copy link
Contributor Author

Oh shoot I forgot all about this.

To be honest the most important data point I was concerned with was how many profiles were defined. I figured it would be worthwhile gathering all the data though for futures inquiries. Anything you think should be left out?

Also - I'm wondering if this should be broken out into an independent plugin so it could be updated mid cycle if there was some information needed. Not actionable for this PR but curious what you're thoughts are on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue has been approved by the bot or manually for further processing needs some work There are some things to do before this PR can be merged targets maintenance The PR targets the maintenance branch
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants